fix(allocator): revert changes to get_current_chunk_footer_field_offset#20964
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 2, 2026
Conversation
Member
Author
This was referenced Apr 2, 2026
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts a small internal change to get_current_chunk_footer_field_offset in oxc_allocator, aligning it with the current Bump implementation to avoid a potential performance regression in Allocator::from_raw_parts’s layout-deduction path.
Changes:
- Construct the dummy
BumpviaBump::<1>::with_min_align()instead ofBump::new()to keep the offset-deduction code simpler for optimization/const-folding. - Simplify the raw pointer derivation with
ptr::from_ref(&bump)(type inference) while preserving behavior.
This was referenced Apr 2, 2026
Base automatically changed from
om/04-01-refactor_allocator_use_latest_bumpalo_as_base_for_bump_
to
main
April 2, 2026 14:54
overlookmotel
force-pushed
the
om/04-02-fix_allocator_revert_changes_to_get_current_chunk_footer_field_offset_
branch
from
5838a7f to
343a594
Compare
overlookmotel
added
the
0-merge
Graphite App
Contributor
Merge activity
|
…set` (#20964) Partial revert of #18168. #18168 made a small change to `get_current_chunk_footer_field_offset` (used by `Allocator::from_raw_parts`). That change was correct in the context of the other changes made to `Bump` in that PR, but now that #20963 has rolled back most of those changes, this change needs to be reverted too as it's a potential perf regression with current version of `Bump`.
graphite-app
bot
force-pushed
the
om/04-02-fix_allocator_revert_changes_to_get_current_chunk_footer_field_offset_
branch
from
343a594 to
fc7f60c
Compare
graphite-app
bot
deleted the
om/04-02-fix_allocator_revert_changes_to_get_current_chunk_footer_field_offset_
branch
leaysgur
pushed a commit
that referenced
this pull request
Apr 7, 2026
### 🐛 Bug Fixes - fc7f60c allocator: Revert changes to `get_current_chunk_footer_field_offset` (#20964) (overlookmotel) - 31316c8 semantic: Rebind class expressions before identifier checks (#20916) (camc314) ### ⚡ Performance - fb52383 napi/parser, linter/plugins: Clear buffers and source texts earlier (#21025) (overlookmotel) - 3b7dec4 napi/parser, linter/plugins: Use `utf8Slice` for decoding UTF-8 strings (#21022) (overlookmotel) - 012c924 napi/parser, linter/plugins: Speed up decoding strings in raw transfer (#21021) (overlookmotel) - 55e1e9b napi/parser, linter/plugins: Initialize vars as 0 (#21020) (overlookmotel) - c25ef02 napi/parser, linter/plugins: Simplify branch condition in `deserializeStr` (#21019) (overlookmotel) - 9f494c3 napi/parser, linter/plugins: Raw transfer use `String.fromCharCode` in string decoding (#21018) (overlookmotel) - 91cf105 allocator: Increase initial chunk size from 512B to 16KB (#20968) (overlookmotel) - cbc0c21 allocator: Add `#[cold]` to to error handling functions (#20967) (overlookmotel) - 0503a78 napi/parser, linter/plugins: Faster deserialization of `raw` fields (#20923) (overlookmotel) - a24f75e napi/parser: Optimize string deserialization for non-ASCII sources (#20834) (Joshua Tuddenham) ### 📚 Documentation - c78a57a syntax: Fix typo (#21044) (camc314) - f5e228f allocator: Fix typo in comment (#20972) (overlookmotel) - 7159d51 allocator: Improve doc comment examples for `vec2::Vec` (#20969) (overlookmotel) - b1da750 allocator, data_structures: Correct comments (#20966) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial revert of #18168.
#18168 made a small change to
get_current_chunk_footer_field_offset(used byAllocator::from_raw_parts).That change was correct in the context of the other changes made to
Bumpin that PR, but now that #20963 has rolled back most of those changes, this change needs to be reverted too as it's a potential perf regression with current version ofBump.